zj/tms-calamares
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

bootloader: Correct a logic error preventing installation on a BIOS-only system

Browse Source 
efi_directory is always set to a value (defaults to /boot/efi) even on a BIOS/CSM/Legacy-only system.
The function is guarded elsewhere to prevent installation of a bios bootloader on UEFI.
This commit is contained in:
zj
2025-12-29 13:46:50 +08:00
parent c71e176d40
commit 845c24cf10
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
calamares/src/modules/bootloader/main.py
View File

@@ -639,12 +639,7 @@ def run_grub_install(fw_type, partitions, efi_directory, install_hybrid_grub):
"--force"]) "--force"])
else: else:
libcalamares.utils.debug("run_grub_install------else bios 1") if libcalamares.globalstorage.value("bootLoader") is None and install_hybrid_grub:
if efi_directory is not None and not install_hybrid_grub:
libcalamares.utils.warning(_("Cannot install BIOS bootloader on UEFI installation when install_hybrid_grub is 'False'!"))
if libcalamares.globalstorage.value("bootLoader") is None:
efi_install_path = libcalamares.globalstorage.value("efiSystemPartition") efi_install_path = libcalamares.globalstorage.value("efiSystemPartition")
if efi_install_path is None or efi_install_path == "": if efi_install_path is None or efi_install_path == "":
efi_install_path = "/boot/efi" efi_install_path = "/boot/efi"
@@ -655,7 +650,6 @@ def run_grub_install(fw_type, partitions, efi_directory, install_hybrid_grub):
return return
boot_loader_install_path = "/dev/" + boot_loader_install_path.split("\n")[1] boot_loader_install_path = "/dev/" + boot_loader_install_path.split("\n")[1]
else: else:
libcalamares.utils.debug("run_grub_install------else bios 1-1 ")
boot_loader = libcalamares.globalstorage.value("bootLoader") boot_loader = libcalamares.globalstorage.value("bootLoader")
boot_loader_install_path = boot_loader["installPath"] boot_loader_install_path = boot_loader["installPath"]
libcalamares.utils.debug(f"boot_loader_install_path: {boot_loader_install_path}") libcalamares.utils.debug(f"boot_loader_install_path: {boot_loader_install_path}")
@@ -666,7 +660,6 @@ def run_grub_install(fw_type, partitions, efi_directory, install_hybrid_grub):
# boot_loader_install_path points to the physical disk to install GRUB # boot_loader_install_path points to the physical disk to install GRUB
# to. It should start with "/dev/", and be at least as long as the # to. It should start with "/dev/", and be at least as long as the
# string "/dev/sda". # string "/dev/sda".
libcalamares.utils.debug("run_grub_install------else bios 2")
if not boot_loader_install_path.startswith("/dev/") or len(boot_loader_install_path) < 8: if not boot_loader_install_path.startswith("/dev/") or len(boot_loader_install_path) < 8:
raise ValueError(f"boot_loader_install_path contains unexpected value '{boot_loader_install_path}'") raise ValueError(f"boot_loader_install_path contains unexpected value '{boot_loader_install_path}'")